2010/5/5 Sergei Shtylyov <sshtylyov@xxxxxxxxxx>:
> Hello.
>
> tom.leiming@xxxxxxxxx wrote:
>
>> From: Ming Lei <tom.leiming@xxxxxxxxx>
>>
>> The plat->mode passed from platform_data always is MUSB_OTG,
>> so the init failures below will happen if we configure musb as
>> HOST or PERIPHERAL mode in Kconfig:
>>
>> "incompatible Kconfig role setting"
>>
>> The patch fixes the issue by degrading otg mode to
>> host or peripheral mode in such case.
>>
>
> Why not fix your platform data instead to pass the needed role like the
> DaVinci code does (see arch/arm/mach-davinci/usb.c)?
IMO, this fix is better than the fix in board code:
-do not need to fix all board code which may support musb
-OTG mode means the hardware has the host-only or peripheral-only
capability
Thanks,
--
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
