On Sun, May 2, 2010 at 5:36 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Sun, May 02, 2010 at 05:22:40PM +0300, Saeed Bishara wrote:
>> @@ -110,6 +111,9 @@ struct usb_hcd {
>> u64 rsrc_start; /* memory/io resource start */
>> u64 rsrc_len; /* memory/io resource length */
>> unsigned power_budget; /* in mA, 0 = no limit */
>> +#if defined(CONFIG_HAVE_CLK)
>> + struct clk *clk;
>> +#endif
>
> We have other hci's using the clk API, why do we need to add this for
> them too? In other words, why can't the orion HCI driver work like
> the other HCI drivers such as ohci-pxa27x.c or ehci-omap.c ?
>
if most of those drivers need clk structure then why not to add it to
the usb_hcd which hold the common stuff?
if I get approval for this then we can change the other drivers to use
this clk instead of each one having its own variable.
saeed
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
