On Fri, Apr 30, 2010 at 04:39:03PM -0400, Alan Stern wrote: > I tried it out (not the USB-3 parts, obviously), and it worked fine. > > Reviewed-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Tested-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Thanks! The as1368 patch that this is based on lets me do this to the UAS driver: drivers/usb/storage/uas.c | 55 ++++++++------------------------------------ 1 files changed, 10 insertions(+), 45 deletions(-) because I can now take out the code that maps and unmaps the SGL passed down from SCSI. Also, with just a couple of lines extra, I included support for OHCI and UHCI controllers (because the USB midlayer handles an SGL with one element), so this feels like a big win to me. Not entirely sure how to handle the patch queue though. I don't have much experience working with quilt, or Greg's tree. I guess I'll put together a new git tree based on Greg's current set of patches, and work on top of that (until I need to rebase). I'll resend this particular patch to linux-usb, adding your tags. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html