>>> On Fri, Apr 09, 2010 at 09:21:20PM +0200, Michal Nazarewicz wrote: >>>> @@ -85,7 +85,7 @@ MODULE_PARM_DESC(iSerialNumber, "SerialNumber string"); >>>> * This function returns the value of the function's bind(), which is >>>> * zero for success else a negative errno value. >>>> */ >>>> -int __init usb_add_function(struct usb_configuration *config, >>>> +int __cold usb_add_function(struct usb_configuration *config, >> Greg KH <greg@xxxxxxxxx> writes: >>> What is the "__cold" for? > On Thu, Apr 29, 2010 at 04:02:55PM -0700, Michal Nazarewicz wrote: >> __init, among other things implies __cold so I left __cold leaving >> out __section. Greg KH <greg@xxxxxxxxx> writes: > Hm, how about just dropping everything? I don't think we need the > __cold here then, right? As you wish. I'm about to resend the whole patchset (probably today or Monday) with some new code so I'll include this change as well. -- Best regards, _ _ .o. | Liege of Serenly Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +--<mina86-tlen.pl>--<jid:mina86-jabber.org>--ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
