From: Dan Carpenter <error27@xxxxxxxxx>
Smatch complained about this missing spinlock.
Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Cc: Anand Gadiyar <gadiyar@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/usb/host/oxu210hp-hcd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN drivers/usb/host/oxu210hp-hcd.c~usb-oxu210hp-release-spinlock-on-error-path drivers/usb/host/oxu210hp-hcd.c
--- a/drivers/usb/host/oxu210hp-hcd.c~usb-oxu210hp-release-spinlock-on-error-path
+++ a/drivers/usb/host/oxu210hp-hcd.c
@@ -660,13 +660,13 @@ static struct ehci_qh *oxu_qh_alloc(stru
if (qh->dummy == NULL) {
oxu_dbg(oxu, "no dummy td\n");
oxu->qh_used[i] = 0;
-
- return NULL;
+ qh = NULL;
+ goto unlock;
}
oxu->qh_used[i] = 1;
}
-
+unlock:
spin_unlock(&oxu->mem_lock);
return qh;
_
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
