On Thu, Apr 22, 2010 at 12:19:33PM -0700, Elina Pasheva wrote:
> +static void sierra_net_send_cmd(struct usbnet *dev,
> + u8 *cmd, int cmdlen, const char * cmd_name)
> +{
> + struct sierra_net_data *priv = sierra_net_get_private(dev);
> + int status;
> +
> + status = usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0),
> + USB_CDC_SEND_ENCAPSULATED_COMMAND,
> + USB_DIR_OUT|USB_TYPE_CLASS|USB_RECIP_INTERFACE, 0,
> + priv->ifnum, cmd, cmdlen, 0);
No timeout?
> + ifnum = priv->ifnum;
> + len = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0),
> + USB_CDC_GET_ENCAPSULATED_RESPONSE,
> + USB_DIR_IN|USB_TYPE_CLASS|USB_RECIP_INTERFACE,
> + 0, ifnum, buf, SIERRA_NET_USBCTL_BUF_LEN, 0);
No timeout?
> + if (unlikely(len < 0)) {
> + netdev_err(dev->net,
> + "usb_control_msg failed, status %d\n", len);
You don't need "unlikely", this is an extreemly slow path here.
Also, what happens for a "short read"? You don't handle that properly.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
