On 04/15/2010 12:33 PM, Sumit Panchasara wrote:
Hi,
I have question regarding usb.c file available on
http://www.linux-usb.org/gadget/usb.c. I am using it to debug Ch9
tests failures from USB20CV software running on Windows host while
attaching dev board configured as device to it.
The source code has handle_control() routine with case for
SET_INTERFACE control requests from gadgetfs module through event
GADGETFS_SETUP.
Now this particular case has following lines of code:
----------------------------------------------------------------------------------------------------
if (ioctl (source_fd, GADGETFS_CLEAR_HALT) < 0) {
status = errno;
perror ("reset source fd");
}
if (ioctl (sink_fd, GADGETFS_CLEAR_HALT) < 0) {
status = errno;
perror ("reset sink fd");
}
----------------------------------------------------------------------------------------------------
My question is, if handle_control() is envoked from ep0 thread with
parent fd, what is a reason to pass "source_fd" and "sink_fd" in ioctl
calls above? Why it is not only 'fd'? Isn't control request handling
should be done on ep0 fd instead of source/sink fd?
If I replace 'source/sink fd' with 'fd' coming with handle_control()
call, it gets captured at gadgetfs and subsequently request goes to my
dev board controller driver as well. With this I am able to pass Ch9
tests from USB20CV software running on Windows Host and configuring my
dev board as device to it.
Is it okay to propose change as follows in usb.c file?
----------------------------------------------------------------------------------------------------
@@ -1476,13 +1476,9 @@
/* just reset toggle/halt for the interface's
endpoints */
status = 0;
- if (ioctl (source_fd, GADGETFS_CLEAR_HALT) < 0) {
+ if (ioctl (fd, GADGETFS_CLEAR_HALT) < 0) {
status = errno;
- perror ("reset source fd");
- }
- if (ioctl (sink_fd, GADGETFS_CLEAR_HALT) < 0) {
- status = errno;
- perror ("reset sink fd");
+ perror ("reset fd");
}
/* FIXME eventually reset the status endpoint too */
if (status)
----------------------------------------------------------------------------------------------------
Thanks,
Sumit
Or the right thing would be adding another if{...} block with ioctl to
'fd' as status endpoint... ?
Thanks,
Sumit
--
_____________________________________________________________________
Disclaimer: This e-mail message and all attachments transmitted with it
are intended solely for the use of the addressee and may contain legally
privileged and confidential information. If the reader of this message
is not the intended recipient, or an employee or agent responsible for
delivering this message to the intended recipient, you are hereby
notified that any dissemination, distribution, copying, or other use of
this message or its attachments is strictly prohibited. If you have
received this message in error, please notify the sender immediately by
replying to this message and please delete it from your computer. Any
views expressed in this message are those of the individual sender
unless otherwise stated.Company has taken enough precautions to prevent
the spread of viruses. However the company accepts no liability for any
damage caused by any virus transmitted by this email.
_____________________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
