On Wed, Apr 14, 2010 at 02:30:52AM -0700, David Brownell wrote: > On Wednesday 07 April 2010, Greg KH wrote: > > You should put a: > > ????????From: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> > > as the first line of the body of this patch, so it properly shows up as > > David's code. > > > > I also would like to get an ack from David that he doesn't mind his code > > moving into the kernel here (personally I think it's a good thing to be > > here.) > > > > thanks, > > ISTR sending an ack .... but, not with a "From:" like that. I did author the > code, but the *patch* is not from me. > > > Omitting all the instructions and the test plan seems like a big mistake, too... Agreed, it should be there as well, as you decribed in the follow-on to the patch. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
