Re: HCD sg_tablesize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 9 Apr 2010, Sarah Sharp wrote:

> > However there's nothing wrong with capping things at some reasonable 
> > size.  If someone tries to submit a request that violates the driver's 
> > specified limit, it's their own fault.  Was Ramya's very large transfer 
> > a single bulk URB?  Did it use scatter-gather?
> 
> Yes, Ramya's transfer was one URB with a scatter-gather list of ~120
> entries.  He was working on a UASP driver that sets the max_sectors
> field in scsi_host_template to 960 or 1024, which makes some of the
> sglists very large.

Then his driver is buggy.  It should limit the length of scatter-gather
lists allowed by the host according to what the HCD can support, the
way usb-storage does:

	host->sg_tablesize = usb_stor_sg_tablesize(intf);

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux