Hi!
>>>>> "eGK" == ext Greg KH writes:
> On Thu, Apr 08, 2010 at 11:11:57AM +0300, Yauheni Kaliuta wrote:
> > >>>>> "eGK" == ext Greg KH writes:
> > > On Wed, Apr 07, 2010 at 08:40:54PM +0300, yauheni.kaliuta@xxxxxxxxx wrote:
> > > > From: Yauheni Kaliuta <yauheni.kaliuta@xxxxxxxxx>
> > > >
[...]
> > > > +struct ndp_parser_opts {
> > > > + uint32_t nth_sign;
> > > > + uint32_t ndp_sign;
> >
> > > u32 please.
> >
> > ok
> >
> > > > + unsigned nth_size;
> > > > + unsigned ndp_size;
> > > > + unsigned ndplen_align;
> > > > + /* sizes in u16 units */
> > > > + unsigned dgram_item_len; /* index or length */
> > > > + unsigned block_length;
> > > > + unsigned fp_index;
> > > > + unsigned reserved1;
> > > > + unsigned reserved2;
> >
> > > reserved for what?
> >
> > struct usb_cdc_ncm_ndp16 {
> > __le32 dwSignature;
> > __le16 wLength;
> > __le16 wNextFpIndex;
> > __u8 data[0];
> > } __attribute__ ((packed));
> >
> > struct usb_cdc_ncm_ndp32 {
> > __le32 dwSignature;
> > __le16 wLength;
> > __le16 wReserved6;
> > __le32 dwNextFpIndex;
> > __le32 dwReserved12;
> > __u8 data[0];
> > } __attribute__ ((packed));
> >
> > reserved by spec, 0 in ndp16 case.
> But why not use the structure itself here?
I want to use the same code to parse structures where some fields are
different both in names and sizes.
> And how do you know that 'unsigned' will be the right size? Please use
I store there size of field in 16 bit usb words, now it's only 0, 1, 2.
More then enough now.
> specific variable sizes if you are relying on them to be a specific
> size.
I do for data, but this is mostly config for parser.
> > > > + unsigned next_fp_index;
> >
> > > Care to be specific about these sizes as well?
> >
> > NextFpIndex size is different for ndp16/32 as well. I'll put a comment.
> Why is it different? Why can't it be the same?
Because of the spec.
> > > > +};
> > > > +
> > > > +#define INIT_NDP16_OPTS { \
> > > > + .nth_sign = NCM_NTH16_SIGN, \
> > > > + .ndp_sign = NCM_NDP16_NOCRC_SIGN, \
> > > > + .nth_size = sizeof(struct usb_cdc_ncm_nth16), \
> > > > + .ndp_size = sizeof(struct usb_cdc_ncm_ndp16), \
> > > > + .ndplen_align = 4, \
> > > > + .dgram_item_len = 1, \
> > > > + .block_length = 1, \
> > > > + .fp_index = 1, \
> > > > + .reserved1 = 0, \
> > > > + .reserved2 = 0, \
> > > > + .next_fp_index = 1, \
> > > > + }
> > > > +
> > > > +
> > > > +#define INIT_NDP32_OPTS { \
> > > > + .nth_sign = NCM_NTH32_SIGN, \
> > > > + .ndp_sign = NCM_NDP32_NOCRC_SIGN, \
> > > > + .nth_size = sizeof(struct usb_cdc_ncm_nth32), \
> > > > + .ndp_size = sizeof(struct usb_cdc_ncm_ndp32), \
> > > > + .ndplen_align = 8, \
> > > > + .dgram_item_len = 2, \
> > > > + .block_length = 2, \
> > > > + .fp_index = 2, \
> > > > + .reserved1 = 1, \
> > > > + .reserved2 = 2, \
> > > > + .next_fp_index = 2, \
> > > > + }
> > > > +
> > > > +static inline void put_ncm(__le16 **p, unsigned size, unsigned val)
> > > > +{
> > > > + switch (size) {
> > > > + case 1:
> > > > + put_unaligned_le16((uint16_t)val, *p);
> > > > + break;
> > > > + case 2:
> > > > + put_unaligned_le32((uint32_t)val, *p);
> > > > +
> > > > + break;
> > > > + default:
> > > > + BUG();
> > > > + }
> > > > +
> > > > + *p += size;
> > > > +}
> >
> > > Don't we have functions for this type of thing already?
> >
> > Thanks a lot, but I could not find it. Could you point?
> I have not looked that hard, but it should be somewhere.
Whould be fine, because I checked and could not find. I asked couple of
guys around, they do not know as well.
--
WBR, Yauheni Kaliuta
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
