Re: [RFC/PATCH 4/8] net: usb: prepare for NCM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 08, 2010 at 11:28:50AM +0300, Yauheni Kaliuta wrote:
> 
> Hi!
> 
> >>>>> "eGK" == ext Greg KH writes:
> 
>  >  On Wed, Apr 07, 2010 at 08:40:56PM +0300, yauheni.kaliuta@xxxxxxxxx wrote:
>  > > --- a/include/linux/usb/usbnet.h
>  > > +++ b/include/linux/usb/usbnet.h
>  > > @@ -43,7 +43,7 @@ struct usbnet {
>  > >          /* protocol/interface state */
>  > >          struct net_device        *net;
>  > >          int                        msg_enable;
>  > > -        unsigned long                data [5];
>  > > +        unsigned long                data[6];
> 
>  > Why do you need to change this?
> 
> well, it's a part of usbnet design. There put struct cdc_state and I'm
> adding one pointer to it.

Ah, that's obvious :)

Shouldn't this be a 'sizeof' type thing somehow?

>  > >          u32                        xid;
>  > >          u32                        hard_mtu;        /* count any extra framing */
>  > >          size_t                        rx_urb_size;        /* size for rx urbs */
>  > > @@ -96,6 +96,8 @@ struct driver_info {
>  > >  #define FLAG_WWAN        0x0400                /* use "wwan%d" names */
>  > >  
>  > >  #define FLAG_LINK_INTR        0x0800                /* updates link (carrier) status */
>  > > +#define FLAG_NO_SHORT        0x1000          /* do not force short transfer */
>  > > +
>  > >  
>  > >          /* init device ... can sleep, or cause probe() failure */
>  > >          int        (*bind)(struct usbnet *, struct usb_interface *);
>  > > @@ -165,6 +167,7 @@ struct cdc_state {
>  > >          struct usb_cdc_ether_desc        *ether;
>  > >          struct usb_interface                *control;
>  > >          struct usb_interface                *data;
>  > > +        struct usb_cdc_ncm_desc                *ncm;
> 
>  > Put this next to the usb_cdc_ether_desc 2 pointers above?
> 
> just a reflex, to keep the old binaries compatible. Will do.

old binaries are never compatible with the kernel :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux