RE: [PATCH 2/5] USB: Add stream ID field to struct urb.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx]
> Sent: Saturday, April 03, 2010 3:34 AM
> To: Greg KH
> Cc: linux-usb@xxxxxxxxxxxxxxx; usb-storage@xxxxxxxxxxxxxxxxxxxxxxxx;
> Hrant Dalalyan; Alan Stern; Paul Zimmerman; Ashot Madatyan
> Subject: [PATCH 2/5] USB: Add stream ID field to struct urb.
> 
> Bulk endpoint streams were added in the USB 3.0 specification.  Streams
> allow a device driver to overload a bulk endpoint so that multiple
> transfers can be queued at once.
> 
> Add a new field, stream_id, to struct urb so that USB 3.0 drivers can
> specify which stream they want the URB to be queued to.
Is this kind of patch planned to be done for scatter-gather
requests? Now usb_sg_request structure has no stream_id
field like urb structure. Also, there is no way to pass the stream_id
field for the selected scatter-gather request using the usb_sg_init function.
The only way to pass the stream_id field for each urb located in
scatter-gather request is loop over the urb list of the scatter-gather
request and set that field manually, which I think is not the best way.
So, please provide your feedback.
> 
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> ---
>  include/linux/usb.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index ce1323c..b6a1fb6 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -1189,6 +1189,7 @@ struct urb {
>  	struct usb_device *dev; 	/* (in) pointer to associated
> device */
>  	struct usb_host_endpoint *ep;	/* (internal) pointer to endpoint
> */
>  	unsigned int pipe;		/* (in) pipe information */
> +	unsigned int stream_id;		/* (in) stream ID */
>  	int status;			/* (return) non-ISO status */
>  	unsigned int transfer_flags;	/* (in) URB_SHORT_NOT_OK | ...*/
>  	void *transfer_buffer;		/* (in) associated data buffer */
> --
> 1.6.3.3
Thanks,
Hrant.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux