On Thu, Apr 1, 2010 at 7:32 PM, Gadiyar, Anand <gadiyar@xxxxxx> wrote: >> Currently,the RX DMA MODE1 is setup only after a packet has sit in the RX fifo. >> I just wonder if this way works?I was told that MODE1 should be setup before >> receiving the first packet,or we have to setup MODE 0 to unload the >> first packet and then >> switch to MODE1 for the remaining packets. >> > > Hi Cliff, > > This part is a little unclear in the spec, but it does indeed work. > > I'll send out a much smaller hack patch that demonstrates how mode1 RX > works when programmed after a packet is already in the fifo - it can > be used with g_zero or g_filestorage, and you can actually see > the throughput improvement and reduced interrupt count. > > There is only one corner case that I could not take care of, that's > why we cannot use this hack patch with all drivers > (most of the code in the patch is already in the driver under > the #ifdef USE_MODE_1 macro) > > The series Felipe posted is a complete rewrite of the MUSB code. > When we're going to take that, I'd like a thorough review first. > It takes care of the corner case I was hitting though, and seems > to work with all gadgets on OMAPs at least. > > > - Anand Hi Anand, Look forward to seeing the patch. Thanks Cliff -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
