Re: [PATCHv2 3/4] usb: otg: twl4030: use the global ULPI register definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Mar 30, 2010 at 02:36:54PM +0200, ext Sergei Shtylyov wrote:
> > @@ -392,11 +299,12 @@ static void twl4030_usb_set_mode(struct twl4030_usb *twl, int mode)
> >  
> >  	switch (mode) {
> >  	case T2_USB_MODE_ULPI:
> > -		twl4030_usb_clear_bits(twl, IFC_CTRL, IFC_CTRL_CARKITMODE);
> > +		twl4030_usb_clear_bits(twl, ULPI_IFC_CTRL,
> > +					ULPI_IFC_CTRL_CARKITMODE);
> >   
> 
>    You might want to convert twl4030_usb_{clear|set}_bits() to use 
> ULPI_{CLR|SET}() too...

OK. I'll resend only this patch unless there is something else.

Thanks.

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux