With patch as1329 (USB: convert to the runtime PM framework), we make USB_SUSPEND depend on PM_RUNTIME instead of CONFIG_PM. Also, CONFIG_USB_OTG selects CONFIG_USB_SUSPEND. If PM_RUNTIME is not enabled, and we try to enable USB_OTG, we will end up with CONFIG_USB_SUSPEND selected. This is due to a known bug with the select statement. This makes the build break on various OMAP configs (which have CONFIG_USB_OTG set by default, but do not yet have CONFIG_PM_RUNTIME enabled). Avoid this by changing the logic for CONFIG_USB_OTG from "select USB_SUSPEND" to "depends on USB_SUSPEND" Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx> CC: Michal Marek <mmarek@xxxxxxx> CC: Tony Lindgren <tony@xxxxxxxxxxx> CC: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> --- Tony already posted a patch to update the defconfigs, so the failing builds are okay now. Resending this patch, as it got lost last time around. drivers/usb/core/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/drivers/usb/core/Kconfig =================================================================== --- linux-2.6.orig/drivers/usb/core/Kconfig 2010-02-21 18:51:31.000000000 +0530 +++ linux-2.6/drivers/usb/core/Kconfig 2010-02-21 18:51:56.000000000 +0530 @@ -109,7 +109,7 @@ config USB_SUSPEND config USB_OTG bool depends on USB && EXPERIMENTAL - select USB_SUSPEND + depends on USB_SUSPEND default n -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html