On Thu, 25 Mar 2010 19:03:37 -0600 Robert Hancock <hancockrwd@xxxxxxxxx> wrote: > This seems like it could be a reasonable approach. The only thing is > that in this code you're returning 1 if the parent device has no DMA > mask set. Wouldn't it make more sense to return 0 in this case? I'm > assuming that in that situation it's a virtual device not backed by > any hardware and there should be no DMA mask restriction... I chose the safer option because I don't know enough how net_device structure is used. If returning zero in such case is always safe, it's fine by me. any example of such virtual device driver? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html