This function forgets to call usb_remove_hcd() or musb_gadget_cleanup() iff sysfs_create_group() fails. Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> --- The patch is against the recent Linus' tree. Changes since the previous version: - moved the addition of the 'status' variable check into patch 3/6. drivers/usb/musb/musb_core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) Index: linux-2.6/drivers/usb/musb/musb_core.c =================================================================== --- linux-2.6.orig/drivers/usb/musb/musb_core.c +++ linux-2.6/drivers/usb/musb/musb_core.c @@ -2050,7 +2050,7 @@ bad_config: #ifdef CONFIG_SYSFS status = sysfs_create_group(&musb->controller->kobj, &musb_attr_group); if (status) - goto fail2; + goto fail3; #endif dev_info(dev, "USB %s mode controller at %p using %s, IRQ %d\n", @@ -2067,6 +2067,11 @@ bad_config: return 0; +fail3: + if (!is_otg_enabled(musb) && is_host_enabled(musb)) + usb_remove_hcd(musb_to_hcd(musb)); + else + musb_gadget_cleanup(musb); fail2: musb_platform_exit(musb); fail: -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
