Re: [PATCH 1/5] usb: otg: add global ULPI register definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 22, 2010 at 11:56:07AM +0100, ext Sergei Shtylyov wrote:
> Heikki Krogerus wrote:
> 
> >>> From: Heikki Krogerus <ext-heikki.krogerus@xxxxxxxxx>
> >>>
> >>> Definitions for registers defined by ULPI specification v1.1.
> >>>
> >>> Signed-off-by: Heikki Krogerus <ext-heikki.krogerus@xxxxxxxxx>
> >>> ---
> >>>  include/linux/usb/ulpi_regs.h |  144 +++++++++++++++++++++++++++++++++++++++++
> >>>   
> >>>       
> >>    Why not simply call it ulpi.h?
> >>     
> >
> > There is already ulpi.h for creating ulpi transceiver.
> 
>    Could add definitions to this file, anyway -- it's pretty useless as 
> is...

For some reason I didn't feel comfortable in having the otg_ulpi_create 
in the same file with the registers and I figured that since many buses 
have their registers defined in *_regs.h file, it's more or less common 
practice, but I guess it doesn't matter. I can combine the two into 
ulpi.h or rename the current ulpi.h into something else unless someone 
thinks otherwise.

Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux