On Sat, 20 Mar 2010, Bruno Prémont wrote: > Add backlight support to PicoLCD device. > > Backlight support depends on backlight class and is only being > compiled if backlight class has been selected. > > Signed-off-by: Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx> > --- > drivers/hid/Kconfig | 2 +- > drivers/hid/hid-picolcd.c | 134 ++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 134 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index a474bcd..5ec3cb7 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -243,8 +243,8 @@ config HID_PICOLCD > - Keypad > - Switching between Firmware and Flash mode > - Framebuffer for monochrome 256x64 display > + - Backlight control (needs CONFIG_BACKLIGHT_CLASS_DEVICE) Wouldn't it be better to have Kconfig rules actually resolve the dependency? I don't see any issue with HID_PICOLCD directly selecting BACKLIGHT_CLASS_DEVICE. Or you can do a separate sub-option for that, if you really want to avoid the direct dependency of the whole driver. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
