This pin-muxing is best done in the board files. The driver need not do this explicitly. Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx> --- Not-tested on 2430 hardware. If someone has a 2430 board, please give this a spin and let me know if something breaks. Also, I don't know why only one pin is muxed inside this file, and what happened to the other eleven. Maybe there is some 2430 history I am missing here; if someone knows why the code was written this way, let me know. I'll post a separate patch to linux-omap to mux all pads for MUSB in the board files. Anyway, there's no reason to keep this in the driver code. drivers/usb/musb/omap2430.c | 6 ------ 1 file changed, 6 deletions(-) Index: linux-2.6/drivers/usb/musb/omap2430.c =================================================================== --- linux-2.6.orig/drivers/usb/musb/omap2430.c 2010-03-20 18:01:14.000000000 +0530 +++ linux-2.6/drivers/usb/musb/omap2430.c 2010-03-20 18:01:20.000000000 +0530 @@ -33,8 +33,6 @@ #include <linux/clk.h> #include <linux/io.h> -#include <plat/mux.h> - #include "musb_core.h" #include "omap2430.h" @@ -199,10 +197,6 @@ int __init musb_platform_init(struct mus u32 l; struct omap_musb_board_data *data = board_data; -#if defined(CONFIG_ARCH_OMAP2430) - omap_cfg_reg(AE5_2430_USB0HS_STP); -#endif - /* We require some kind of external transceiver, hooked * up through ULPI. TWL4030-family PMICs include one, * which needs a driver, drivers aren't always needed. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html