Konrad Rzeszutek Wilk wrote: >> +/* >> + * The mem2_dma "device". >> + * >> + * This device "owns" a pool of coherent MEM2 memory that can be shared among >> + * several devices requiring MEM2 DMA buffers, instead of dedicating specific >> + * pools for each device. >> + * >> + * A device can use the shared coherent MEM2 memory pool by calling >> + * wii_set_mem2_dma_constraints(). >> + * >> + */ >> + >> +struct mem2_dma { >> + struct platform_device *pdev; >> + > > The space there isn't neccessary. > Yes. Having it or not is just a matter of formatting style taste. >> + dma_addr_t dma_base; > > I think you need only one of them. You don't seem to use 'base' >> + void *base; >> + size_t size; >> +}; > I can even get rid of the whole struct mem2_dma and just use a struct platform_device now that there's no mem2_dma_exit() function. I'll do that on the next iteration. Thanks for your comments. Cheers, Albert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html