Re: [RFC][PATCH 20/20] USB: aircable: rewrite using generic read and write implementations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Kill circular buffers for tx and rx as well as read work thread, and
switch to generic kfifo-based write implementation.

This is an example of how prepare_write_buffer and process_read_urb can
be used to handle protocols with packet headers.

Please note the diffstat which shows that the same functionality is now
provided using only a tenth of the code (including whitespace and
comments, though).

Compile-only tested.

Cc: Naranjo, Manuel Francisco<naranjo.manuel@xxxxxxxxx>
Signed-off-by: Johan Hovold<jhovold@xxxxxxxxx>
---
....

Is there any site where I can grab your code? So I can compile and test it on real hardware. Patch is large enough to get lost.

But I remember copying lots of code from pl2303 so if you have made methods generic enough it should take me long to test (other than compiling). Would be glad if the patch works, it's a great improvement 450 lines removed! wow that's a huge difference.

Manuel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux