On Wed, Mar 17, 2010 at 05:47:05PM +0800, Crane Cai wrote: > On Tue, Mar 16, 2010 at 10:51:50AM -0700, Sarah Sharp wrote: > System software triggered port power management will only be called via the > sysfs interface which only exists when the device is configured. > > > It does not hurt to ring the doorbell unconditionally. If there is no > > TDs on the ring, then nothing happens, other than the host controller > > fetches a TD it doesn't own. > > > > It also doesn't hurt to issue a stop endpoint command for a disabled > > device. The stop endpoint command handler will ignore the status that > > comes back for that command completion. In fact, the original code > > won't do anything at all unless there are TDs on the cancellation list. > > The USB core shouldn't suspend a device unless all URBs are completed > > and the device has been idle for a while, so there should never be TDs > > on the cancellation list. > > I think we can avoid any redundent action if possible. If you require > unconditionaly do them, I will follow you. It's probably better to do them unconditionally, just to be on the safe side. We can optimize it later if we find there is a performance problem or bugs. > Sarah all others I will follow your suggestion. Thank you for your intensive > comments. No problem. :) Thank you for taking the time to rework patches. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
