RE: [PATCH] cdc_acm: add reset_resume method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > 
> > > If the device has been reset chances are that any connection has been
> > > dropped already due to the reset. We really should notify the upper layers
> > > of that.
> > > If you simply remove the call upper layers will have to deal with odd
> > > situations.
> > 
> > And security risk in some cases, because you will miss the modem on a
> > port dropping and being called from elsewhere if the serial port happened
> > to be suspended at that point. Usually won't matter but with things like
> > remote management login you don't want that to happen !
> 
> Understood - thanks!
> 
> By the way, I was wondering how the device node changes from ttyACMx to
> ttyACM(x+1) without the tty_hangup() call - and I notice that removing
> this call makes no difference - the device node remains the same.
> 
> I suppose this is expected behavior then, and the changelog was incorrect?
> The only reason for the tty_hangup calls are the ones you 
> mention above, right?
> 

Re-reading the changelog, I understand better now. Without the
.reset_resume implemented, the device node increments. And with
the .reset_resume, it does not.

Sorry for the noise and thanks again for the info.

- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux