On Mon, Mar 15, 2010 at 04:16:52PM -0700, Greg KH wrote: > On Mon, Mar 15, 2010 at 10:46:34PM +0000, David Vrabel wrote: > > Greg KH wrote: > > > On Tue, Mar 02, 2010 at 01:05:40PM -0800, Matthew Wilcox wrote: > > >> On Tue, Mar 02, 2010 at 08:24:15PM +0000, David Vrabel wrote: > > >>> Sarah Sharp wrote: > > >>>> From: Matthew Wilcox <willy@xxxxxxxxxxxxxxx> > > >>>> > > >>>> USB 3 and Wireless USB specify a logarithmic encoding of the endpoint > > >>>> interval that matches the USB 2 specification. usb_fill_int_urb() > > >>>> didn't know that and was filling in the interval as if it was USB 1.1. > > >>>> As noted in the updated comment, Wireless USB uses 128us instead of 125us, > > >>>> but it's still logarithmic. > > >>> The rest of the system requires that urb->interval for WUSB urbs uses > > >>> the bInterval encoding. So don't change this function for WUSB. > > >> That, um, doesn't seem like the best design decision. It seems to me > > >> that we should have a consistent encoding in urb->interval no matter what > > >> the underlying *hci is. Whether that means that USB2 should be changed, > > >> or WUSB should be changed (and at this point, I have no idea whether USB3 > > >> is doing the right thing or not), I really don't have a strong opinion. > > >> But I do think that USB2, WUSB and USB3 should do the _same_ thing. > > >> Do you agree? > > > > > > David, ping? > > > > I'm not sure what you're waiting for. Given that urb->interval will > > eventually go away I see no problem with the inconsistancy between > > different types of devices remaining for the time being. Sarah or > > Matthew should respin the patch to only affect Superspeed devices. > > Ok, Sarah, Matthew, someone care to redo the patch please? I'm redoing the patch, but I'm having system crashes on 2.6.34-rc1 with a flaky xHCI host controller, and I'm trying to track that down first. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
