Re: [PATCH] xHCI: re-initialize cmd_completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 12, 2010 at 05:10:04PM +0800, Andiry Xu wrote:
> >From e95ad0a0f19f7f146133da830061de2d652b789d Mon Sep 17 00:00:00 2001
> From: Andiry Xu <andiry.xu@xxxxxxx>
> Date: Wed, 10 Mar 2010 15:06:06 +0800
> Subject: [PATCH] xHCI: re-initialize cmd_completion
> 
> When a signal interrupts a Configure Endpoint command, the cmd_completion used
> in xhci_configure_endpoint() is not re-initialized and the
> wait_for_completion_interruptible_timeout() will return failure. Initialize
> cmd_completion in xhci_configure_endpoint().
> 
> Signed-off-by: Andiry Xu <andiry.xu@xxxxxxx>

Greg,

This should go into the 2.6.32 and 2.6.33 stable trees as well.

Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/host/xhci-hcd.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-hcd.c b/drivers/usb/host/xhci-hcd.c
> index 4cb69e0..492a61c 100644
> --- a/drivers/usb/host/xhci-hcd.c
> +++ b/drivers/usb/host/xhci-hcd.c
> @@ -1173,6 +1173,7 @@ static int xhci_configure_endpoint(struct xhci_hcd *xhci,
>  		cmd_completion = &virt_dev->cmd_completion;
>  		cmd_status = &virt_dev->cmd_status;
>  	}
> +	init_completion(cmd_completion);
>  
>  	if (!ctx_change)
>  		ret = xhci_queue_configure_endpoint(xhci, in_ctx->dma,
> -- 
> 1.6.3.3
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux