Re: [PATCH] USB: musb: support host/gadget role switching on Blackfin parts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Feb 03, 2010 at 04:35:25AM +0100, ext Cai, Cliff wrote:
you read the same DEVCTL register over and over again. Read it
once and only change the bits you want to change:

val = musb_readw(musb->mregs, MUSB_DEVCTL); val &=
~MUSB_DEVCTL_SESSION; musb_writew(musb->mregs, MUSB_DEVCTL,
val); val |= MUSB_DEVCTL_SESSION; musb_writew(musb->mregs,
MUSB_DEVCTL, val);

btw, why do you disable and right after reenable session bit ?
A little comment would make things clearer, is that really necessary ?

It's really necessary,or if musb is in host mode,then it can't detect
the B-plug
If it's connected to PC.

ok, still you didn't fix the several reads of DEVCTL in a row.

could you provide a new version of the patch ?

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux