Re: [RFC] xhci: Add logging levels and reduce excessive verbosity.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-03-08 at 23:10 -0800, Sarah Sharp wrote:
> Add a new module parameter, log_level to the xHCI driver.  This will allow
> developers to select which type of debugging messages they want to see.
> log_level is a bit mask, so multiple types of debugging can be selected.
> This new parameter will prevent log file corruption when
> CONFIG_USB_XHCI_HCD_DEBUGGING is set to 'y'.
> 
> All calls to xhci_dbg() must now include a log level as the second
> parameter.  There are eleven different log levels to choose from:
>  - XHCI_LOG_QUIRKS
>  - XHCI_LOG_COMMANDS
>  - XHCI_LOG_COMMANDS_VERBOSE
>  - XHCI_LOG_INIT
>  - XHCI_LOG_EVENTS
>  - XHCI_LOG_DEVICE_STATE
>  - XHCI_LOG_TX
>  - XHCI_LOG_TX_VERBOSE
>  - XHCI_LOG_NOOPS
>  - XHCI_LOG_RINGS
>  - XHCI_LOG_PORTS
>  - XHCI_LOG_REGS
> 
> The default displayed debugging is messages with log level
> XHCI_LOG_QUIRKS, XHCI_LOG_COMMANDS, or XHCI_LOG_TX.
> 
> While we're at it, remove unnecessary debugging messages that provide
> little useful information.
> 
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> ---
> 
> Andiry, Libin, Cran, and Dong,
> 
> Can you try this patch out and see if the number of debugging messages
> from the xHCI driver is more tolerable?  It looks much better to me, but
> please let me know if you spot more redundant or not useful debugging
> messages.
> 

Yes, I have tried the patch and it's really much better now. Thanks for
the effort.


-- 

Thanks,
Andiry

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux