On Tue, Mar 09, 2010 at 11:32:27AM -0700, Alex Chiang wrote: > * Greg KH <greg@xxxxxxxxx>: > > On Tue, Mar 09, 2010 at 10:52:43AM -0700, Alex Chiang wrote: > > > > > USB: xhci: move all debug code under CONFIG_XHCI_HCD_DEBUGGING > > > > Does this conflict with Sarah's other debugging patch she just sent out? > > I'm assuming you're talking about this patch: > > http://thread.gmane.org/gmane.linux.usb.general/28681 Yes. > Yes, we'll definitely have conflicts. If you agree that we should > move the debug code under the Kconfig option, then the best > course of action would be for Sarah to rebase her work on top of > my patches (since they're intrusive). As Sarah is the maintainer of the file, I'll leave that decision up to her :) And keeping a config option for debugging isn't a good idea. The rest of the kernel has switched to using dynamic debugging, so that distros and others can easily get information without requiring a kernel rebuild (which we can't expect users to always be able to do.) So I would not recommend this change. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
