RE: [PATCH] USB: musb: fix build error introduced by isoc change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mike Frysinger wrote:
> 
> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
> 
> The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
> seems to have been against an older kernel version.  It uses the old style
> naming of variables.  Unfortunately, this breaks building for most MUSB
> users out there since "bDesiredMode" has been renamed to "desired_mode".
> 

Looks like this code is under a "#ifdef USE_MODE1" check; that's why
we did not find this during regular builds. Felipe's upcoming patches
would make this code redundant anyway.

Till then, we might as well fix it.

> Signed-off-by: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>

Acked-by: Anand Gadiyar <gadiyar@xxxxxx>

> ---
>  drivers/usb/musb/musb_host.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index d21fffa..ef29f38 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -1689,7 +1689,7 @@ void musb_host_rx(struct musb *musb, u8 epnum)
>                                 dma->desired_mode = 1;
>                         if (rx_count < hw_ep->max_packet_sz_rx) {
>                                 length = rx_count;
> -                               dma->bDesiredMode = 0;
> +                               dma->desired_mode = 0;
>                         } else {
>                                 length = urb->transfer_buffer_length;
>                         }
> --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux