> On Fri, 5 Mar 2010, Libin wrote: > > > On Wed, 2010-03-03 at 10:53 -0500, Alan Stern wrote: > > > On Wed, 3 Mar 2010, Libin wrote: > > > > > > > >From d3055401927f70e4de7717138b4c8ecad8b8223a Mon Sep 17 00:00:00 > 2001 > > > > From: Libin Yang <libin.yang@xxxxxxx> > > > > Date: Wed, 3 Mar 2010 13:50:41 +0800 > > > > Subject: [PATCH 3/5] xHCI: bus power management implementation > > > > > > > > This patch implements xHCI bus suspend/resume function hook. > > > > > > > > In the patch it goes through all the ports and suspend/resume > > > > the ports if needed. > > > > > > It looks like you have been basing your work on an old version of > > > ehci-hcd. You need to look at the most recent drivers in Greg's tree > > > for changes. > > > > Yes, the patch is based on the old ehci-hcd. Thanks for the suggestion > > and I will check out Greg's most recent tree. > > > > > The thing I noticed is that your bus suspend routine should abort the > > > suspend if a port is in the middle of a remote wakeup. > > > > Most of the code is referring the ehci driver code and enable the remote > > wake up at the end of code. Do you mean that before enabling the remote > > wake up, I need to check do_remote_wakeup? > > Look at the most recent ehci-hub.c file. Before bus_suspend() does > anything else, it checks to see whether any ports are in the middle of > a wakeup. If they are, it fails the suspend. Thanks. I will modify the xhci_bus_suspend() based on ehci-hub.c. > > Alan Stern > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
