Re: [PATCH] usb: usbfs: Fix deadlock of khubd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 06, 2010 at 04:16:12PM -0800, Greg KH wrote:
> On Sat, Mar 06, 2010 at 06:27:37PM -0500, Alan Stern wrote:
> > On Sat, 6 Mar 2010, Linus Torvalds wrote:
> > 
> > > > Applied the patch. It works for me. "cat /proc/bus/usb/devices" works
> > > > (vmware works as well)!!!
> > > 
> > > Goodie. Alan, Greg, others - should I just commit it, or wait for you send 
> > > it back to me? Acks or nak's?
> > 
> > It looks sane to me.  But Greg is the maintainer...
> 
> Heh, looks good to me as well, so feel free to add an:
> 	Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> and commit it to your tree.
> 
> Thanks for fixing this up,
> 

And just a small followup...

-- 
Dmitry

USB: remove unused defintion of struct usb_device_status

The recent rework of /proc/bus/usb/devices polling support made
this structure unused so let's remove it.

Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
---

 drivers/usb/core/devices.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)


diff --git a/drivers/usb/core/devices.c b/drivers/usb/core/devices.c
index 6053a8b..d41811b 100644
--- a/drivers/usb/core/devices.c
+++ b/drivers/usb/core/devices.c
@@ -133,11 +133,6 @@ static struct device_connect_event {
 	.wait = __WAIT_QUEUE_HEAD_INITIALIZER(device_event.wait)
 };
 
-/* this struct stores the poll state for <mountpoint>/devices pollers */
-struct usb_device_status {
-	unsigned int lastev;
-};
-
 struct class_info {
 	int class;
 	char *class_name;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux