goku_udc: another potential null deref?

[Dan Carpenter <error27@xxxxxxxxx>]

Smatch also this:
drivers/usb/gadget/goku_udc.c +1633 goku_irq(83) error: dereferencing undefined:  'dev->driver'

  1621                                  if (dev->gadget.speed != USB_SPEED_UNKNOWN
  1622                                                  && dev->driver
  1623                                                  && dev->driver->resume) {

	We assume "dev->driver" is possibly null here.

  1624                                          spin_unlock(&dev->lock);
  1625                                          dev->driver->resume(&dev->gadget);
  1626                                          spin_lock(&dev->lock);
  1627                                  }
  1628                          }
  1629                  }
  1630  pm_next:
  1631                  if (stat & INT_USBRESET) {              /* hub reset done */
  1632                          ACK(INT_USBRESET);
  1633                          INFO(dev, "USB reset done, gadget %s\n",
  1634                                  dev->driver->driver.name);
	
	We dereference it unconditionally here.

  1635                  }

Should I add a check on line 1634?

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html