Re: [PATCH RFC 5/5] xHCI port PM: set U1/U2 timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Mittwoch, 3. März 2010 11:11:30 schrieb Libin:
> +#if 0
> +       /* Set PORT PMSC */
> +       ports = HCS_MAX_PORTS(xhci->hcs_params1);
> +       port = udev->portnum;
> +       if ((port <= 0) || (port > ports)) {
> +               xhci_warn(xhci, "Invalid port id %d\n", port);
> +               return 0;
> +       }
> +       addr = &xhci->op_regs->port_power_base + NUM_PORT_REGS * (port - 1);
> +       temp = xhci_readl(xhci, addr);
> +
> +       switch (udev->speed) {
> +       case USB_SPEED_SUPER:
> +               /* Set U1/U2 timeout */
> +               /* FIXME: how to decide appropriate value? */
> +               temp |= PORT_U1_TIMEOUT(0x7f);
> +               temp |= PORT_U2_TIMEOUT(0xff);
> +               xhci_writel(xhci, temp, addr);
> +               xhci_dbg(xhci, "Set SS port %d U1/U2 timeout\n", port);
> +               break;

It seems to me that theses values will have to be derived from the pm_qos
framework. There's no way the kernel can come up with sensible values.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux