On Tue, Mar 02, 2010 at 06:49:03PM +0800, Libin Yang wrote: > >From a37170e23f1a0dc1fc88ceee305ede6e90de6659 Mon Sep 17 00:00:00 2001 > From: Andiry Xu <andiry.xu@xxxxxxx> > Date: Tue, 2 Mar 2010 17:15:36 +0800 > Subject: [PATCH 7/7] xHCI: re-initialize cmd_completion > > When a signal interrupts isoc transfer, the cmd_completion used in > xhci_configure_endpoint() is not re-initialized and the > wait_for_completion_interruptible_timeout() will return failure. > Initialize the cmd_completion in xhci_configure_endpoint(). While I agree with the contents of this patch (thanks for catching this!), I'm a little puzzled by the description. I didn't see you issue a configure endpoint command as part of an isochronous transfer. Am I missing something, or did you forget part of the patchset? Sarah Sharp > Signed-off-by: Libin Yang <libin.yang@xxxxxxx> > --- > drivers/usb/host/xhci-hcd.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/host/xhci-hcd.c b/drivers/usb/host/xhci-hcd.c > index 90d373c..eaa5aae 100644 > --- a/drivers/usb/host/xhci-hcd.c > +++ b/drivers/usb/host/xhci-hcd.c > @@ -1229,6 +1229,7 @@ static int xhci_configure_endpoint(struct xhci_hcd *xhci, > cmd_completion = &virt_dev->cmd_completion; > cmd_status = &virt_dev->cmd_status; > } > + init_completion(cmd_completion); > > if (!ctx_change) > ret = xhci_queue_configure_endpoint(xhci, in_ctx->dma, > -- > 1.6.0.4 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
