On Fri, Feb 12, 2010 at 8:49 PM, Gadiyar, Anand <gadiyar@xxxxxx> wrote:
> jidong xiao wrote:
>> On Fri, Feb 12, 2010 at 7:17 PM, Gadiyar, Anand <gadiyar@xxxxxx> wrote:
>> > Greg,
>> >
>> > I'm building current Linus' tree + gregkh-03-usb.current-2.6.33-rc7.patch
>> > and gregkh-07-usb-2.6.33-rc7.patch for OMAP3 and I see the
>> > following compile error:
>> >
>> > CC drivers/usb/core/hcd.o
>> > drivers/usb/core/hcd.c: In function 'usb_hcd_resume_root_hub':
>> > drivers/usb/core/hcd.c:1892: error: 'pm_wq' undeclared (first use in this function)
>> > drivers/usb/core/hcd.c:1892: error: (Each undeclared identifier is reported only once
>> > drivers/usb/core/hcd.c:1892: error: for each function it appears in.)
>> > make[3]: *** [drivers/usb/core/hcd.o] Error 1
>> > make[2]: *** [drivers/usb/core] Error 2
>> > make[1]: *** [drivers/usb] Error 2
>> > make: *** [drivers] Error 2
>> >
>> > Just reporting it now - maybe a dependency is all I'm missing.
>> >
>>
>> I guess you did _not_ enable CONFIG_PM_RUNTIME, right?
>>
>> pm_wq is only defined when CONFIG_PM_RUNTIME is enabled.
>>
>> 15 #ifdef CONFIG_PM_RUNTIME
>> 16
>> 17 extern struct workqueue_struct *pm_wq;
>
> Right, I had CONFIG_PM_RUNTIME disabled. Enabling it allowed the
> compile to go through.
>
> Does that compile failure still needs to be fixed. I'm guessing
> not everyone will build with this option enabled?
>
Well, looking at gregkh-07-usb-2.6.33-rc7.patch, I noticed following
hunk of patch:
diff -Naur -X linux-2.6.33-rc7-tty/Documentation/dontdiff
linux-2.6.33-rc7-tty/drivers/usb/core/Kconfig
linux-2.6.33-rc7-usb/drivers/usb/core/Kconfig
--- linux-2.6.33-rc7-tty/drivers/usb/core/Kconfig 2009-09-09
15:13:59.000000000 -0700
+++ linux-2.6.33-rc7-usb/drivers/usb/core/Kconfig 2010-02-09
13:21:32.000000000 -0800
@@ -91,8 +91,8 @@
If you are unsure about this, say N here.
config USB_SUSPEND
- bool "USB selective suspend/resume and wakeup"
- depends on USB && PM
+ bool "USB runtime power management (suspend/resume and wakeup)"
+ depends on USB && PM_RUNTIME
help
If you say Y here, you can use driver calls or the sysfs
"power/level" file to suspend or resume individual USB
This patch is saying, USB_SUSPEND is depends on PM_RUNTIME, in your
case, USB_SUSPEND is enabled, but PM_RUNTIME is disabled, this is a
little bit strange, I guess you have manually edited .config instead
of running the command `make menuconfig`. I am afraid this might cause
some dependency problem.
Regards
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
