Review and minor fixes for ftdi_sio.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 5, 2010 at 6:38 PM, Greg KH <greg@xxxxxxxxx> wrote:
> On Fri, Feb 05, 2010 at 11:54:56AM +0200, Vitaly V. Ch wrote:
>> Hi all!
>>
>> I'm find then ftdi_sio.c in 2.4.37.8 kernel have next bug: if I have
>> three ftdi-232 simultaneously connected to middle-loaded host,
>> application which use one of them will hung in driver, usually during
>> few hour.
>
> Can you look at the version in 2.6.33-rc6, and also in the linux-next
> tree?  Both of those have changes to this driver already done, and
> hopefully this fixes your problem.

1)
Yes, I will see in that files but I can't use 2.6.xx kernel. I will
backport fixes to 2.4.37.8.


2)
> I don't know, what is the problem you are seeing here?

In kernel sources we have:

    else if (divisor == 1)
        divisor = 0;    /* special case for maximum baud rate */

But there are reason to wait at this place:

     if (divisor == 1)
         divisor = 0;    /* special case for maximum baud rate */

last version of code I found in driver downloaded from ftdichip.com.
and i'm not sure which of them is right. if anyone know - it will be
interested.


> If not, can you send a patch that I can apply (read
> Documentation/SubmittingPatches for how to do it)?

Ok, I will do it

>
> thanks,
>
> greg k-h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux