Re: [patch 1/1] musb: test always evaluates to false

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 02 February 2010, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
>         /* driver must be initialized to support peripheral mode */
> -       if (!musb || !(musb->board_mode == MUSB_OTG
> -                               || musb->board_mode != MUSB_OTG)) {
> +       if (!musb) {
>                 DBG(1, "%s, no dev??\n", __func__);
>                 return -ENODEV;
>         }


Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>


... I suspect that's a remnant of very ancient code, but in any
case "musb" will be NULL unless the board mode includes peripheral
mode support (e.g. a Mini-B or Mini-AB connector; or Micro-AB).

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux