Hi, On Tue, Feb 02, 2010 at 01:07:56PM +0100, Oliver Neukum wrote: > Am Dienstag, 2. Februar 2010 13:01:12 schrieb Catalin Marinas: > > On Tue, 2010-02-02 at 11:48 +0000, Oliver Neukum wrote: > > > Am Montag, 1. Februar 2010 18:29:14 schrieb Catalin Marinas: > > > Is it correct to limit this to BULK pipes? > > > > I'm not entirely sure. The flush_dcache_page() should only be called for > > pages that may be mapped into user space (page cache pages). We don't > > need this for control buffers. It was my impression that what's coming > > from the mass storage layer intended for page cache pages has the > > PIPE_BULK type (I may be wrong though). > > For storage that is correct. But what about other sources of pages, > for example iSCSI? Or... usb-audio? I should have verified that it is using bulk endpoints (and thus the patch applies to my case). usb-audio probably uses isochronous transfers, thus that would be an obvious reason why the patch didn't work for me. (with some other reason possibly being BCM4710 issues, of course) Andreas Mohr -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
