On Tue, Feb 02, 2010 at 11:05:39AM +0000, Catalin Marinas wrote: > On Tue, 2010-02-02 at 06:39 +0000, Paul Mundt wrote: > > On Mon, Feb 01, 2010 at 05:29:14PM +0000, Catalin Marinas wrote: > > > diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c > > > index 27b8f7c..4d3eeee 100644 > > > --- a/drivers/usb/host/isp1760-hcd.c > > > +++ b/drivers/usb/host/isp1760-hcd.c > > > @@ -18,6 +18,8 @@ > > > #include <linux/uaccess.h> > > > #include <linux/io.h> > > > #include <asm/unaligned.h> > > > +#include <asm/cacheflush.h> > > > +#include <asm/memory.h> > > > > asm/memory.h isn't a portable header. If you are including it for > > virt_to_page(), linux/io.h should already bring that in via asm/io.h. > > If arm doesn't bring in virt_to_page() through its asm/io.h, then fix the > > headers there please. > > In the ARM case, yes, it brings virt_to_page() but I'm not sure that's > the case for the other architectures. I think a better header is > linux/mm.h which already uses this function in virt_to_head_page(). > For some reason I was thinking virt_to_phys() instead of virt_to_page() when I wrote that, so just ignore me. linux/mm.h is obviously fine. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
