Re: [PATCH] USB: musb: allow the Blackfin vrsel gpio to be active low

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Jan 29, 2010 at 02:56:08AM +0100, ext Mike Frysinger wrote:
@@ -248,9 +248,9 @@ static void bfin_vbus_power(struct musb *musb, int is_on, int sleeping)
static void bfin_set_vbus(struct musb *musb, int is_on)
{
	if (is_on)
-		gpio_set_value(musb->config->gpio_vrsel, 1);
+		gpio_set_value(musb->config->gpio_vrsel, musb->config->gpio_vrsel_active);

line is waaaaaaaaay over 80-chars :-)

	else
-		gpio_set_value(musb->config->gpio_vrsel, 0);
+		gpio_set_value(musb->config->gpio_vrsel, !musb->config->gpio_vrsel_active);

ditto.


	DBG(1, "VBUS %s, devctl %02x "
		/* otg %3x conf %08x prcm %08x */ "\n",
diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
index d437556..cd2be44 100644
--- a/include/linux/usb/musb.h
+++ b/include/linux/usb/musb.h
@@ -53,6 +53,7 @@ struct musb_hdrc_config {
#ifdef CONFIG_BLACKFIN
        /* A GPIO controlling VRSEL in Blackfin */
        unsigned int    gpio_vrsel;

these two lines above are indented with spaces ??

+	unsigned int	gpio_vrsel_active;

for now, this is ok.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux