On Thu, Jan 28, 2010 at 12:32, Felipe Balbi wrote:
> On Thu, Jan 28, 2010 at 02:40:03AM +0100, ext Mike Frysinger wrote:
>>
>> @@ -462,7 +462,10 @@ static inline u8 musb_read_configdata(void __iomem
>> *mbase)
>>
>> static inline u16 musb_read_hwvers(void __iomem *mbase)
>> {
>> - return 0;
>> + /* This register is invisible on Blackfin, actually the MUSB
>> + * RTL version of Blackfin is 1.9, So just set it's value to 1.9.
>> + */
>> + return 1 << 10 | 9;
>
> I believe musb would read 1.9 as:
>
> 1 << 10 | 900, but how about the following:
>
> diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h
> index 1e3da4e..0842f30 100644
> --- a/drivers/usb/musb/musb_core.h
> +++ b/drivers/usb/musb/musb_core.h
> @@ -330,6 +330,7 @@ struct musb {
> #define MUSB_HWVERS_1300 0x52C
> #define MUSB_HWVERS_1400 0x590
> #define MUSB_HWVERS_1800 0x720
> +#define MUSB_HWVERS_1900 0x784
> #define MUSB_HWVERS_2000 0x800
> u16 hwvers;
> diff --git a/drivers/usb/musb/musb_regs.h b/drivers/usb/musb/musb_regs.h
> index 895fb05..2dbfaa5 100644
> --- a/drivers/usb/musb/musb_regs.h
> +++ b/drivers/usb/musb/musb_regs.h
> @@ -533,7 +533,11 @@ static inline u8 musb_read_configdata(void __iomem
> *mbase)
> static inline u16 musb_read_hwvers(void __iomem *mbase)
> {
> - return 0;
> + /* This register is invisible on Blackfin, actually the MUSB
> + * RTL version of Blackfin is 1.9, So just set it's value to 1.9.
> + */
> +
> + return MUSB_HWVERS_1900;
> }
> static inline void __iomem *musb_read_target_reg_base(u8 i, void __iomem
> *mbase)
that seems logical (based on the other values) and it's not like the
magical hardcoded value matters to us at all :), so Signed-off-by me.
thanks.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
