Re: USB: serial: mct_usb232: add drain on close

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 24, 2010 at 11:21:50PM -0700, Pete Zaitcev wrote:
> On Sun, 24 Jan 2010 18:54:13 +0100
> Johan Hovold <jhovold@xxxxxxxxx> wrote:
> 
> > > > > +	port->port.drain_delay = 2;
> > > > > +
> > > > 
> > > > You need to set drain_delay in open rather than close, as drain wait is
> > > > done before driver-specific close is called (see tty_port_close).
> > > 
> > > OK, I'll review this. My actual tests worked correctly with the
> > > above code (in release method) and failed without. And the bug is
> > > easily reproducible. But perhaps something changed in the last second
> > 
> > It can not work the first time you close the port after port probe, as
> > drain_delay will be uninitialised (0). The next time the port is closed
> > however, drain_delay will have been set correctly.
> 
> You are probably right. However, I went to test this today (meaning to
> relocate the assignment as you suggest), and for some reason I cannot
> reproduce the problem on an unmodified 2.6.33-rc5. I think I should ask
> Greg to cancel this until at least I know what is going on.

Ok, I'll ignore this for now :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux