Am Donnerstag, 28. Januar 2010 08:24:26 schrieben Sie: > > Again, like I said, I don't have a problem changing it. If it's wrong, > > it's wrong no matter how many other drivers may take the same > > approach. > > I believe it is wrong. So do I. You need not fail if copy_to_user() fails, but if you go that route you need to evaluate the return value of copy_to_user() and return: not_written = copy_to_user(...); return to_be_written - not_written ? to_be_written - not_written : -EFAULT; Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html