Re: [PATCH] USB: serial: Fix atomic schedule in u_serial.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 21, 2010 at 02:03:40PM +0800, River Wang wrote:
> Hi All:
>     When tty->low_latency = 1, tty_flip_buffer_push() may sleep in
> tasklet context which will lead to a kernel crash.We use
> workqueue instead of tasklet.
> 
> Signed-off-by: Wang Zhi <coredump007@xxxxxxxxx>
> ---
> --- a/drivers/usb/gadget/u_serial.c     2010-01-19 02:23:35.000000000 +0800
> +++ b/drivers/usb/gadget/u_serial.c     2010-01-20 14:42:17.000000000 +0800
> @@ -105,7 +105,7 @@ struct gs_port {
>        struct list_head        read_pool;
>        struct list_head        read_queue;
>        unsigned                n_read;
> -       struct tasklet_struct   push;
> +       struct work_struct      push;
> 
>        struct list_head        write_pool;
>        struct gs_buf           port_write_buf;

Your email client stripped off all tabs and converted them to spaces.

Can you read the file, Documentation/email_clients.txt and then resend
the patch?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux