Re: [patch] usb: io_edgeport: eliminate get_string()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 25, 2010 at 11:13:29PM +0100, Johan Hovold wrote:
> On Mon, Jan 25, 2010 at 10:47:31PM +0100, Oliver Neukum wrote:
> > Am Montag, 25. Januar 2010 21:54:16 schrieb Johan Hovold:
> > > I don't think this patch should go to stable as it does not fix anything
> > > severe. Worst case is that in the unlikely event that usb_control_msg
> > > fails and you have debugging enabled one may end up with 64 non-sense
> > > characters in you log. There's no risk for any memory corruption
> > > AFAICT.
> > 
> > It does fix DMA on the stack. Are you sure this is always harmless
> > on non-x86?
> 
> Good point. But if that is considered critical enough then Dan's
> original patch should go to stable instead of this one. And so should
> the other 10+ DMA-to-stack patches in Greg's tree?

Given the age of this bug (1999) and the fact that the devices are no
longer made, I don't think this is -stable worthy.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux