On Fri, Jan 01, 2010 at 02:06:26PM -0500, Mike Dunn wrote: > Hi folks, > > I'm hoping to solicit some guidance on how a driver for this device > could fit into the usb driver code base. It is an odd creature that > implements a serial port and IEEE 1284-compliant parallel port, both on > the same usb interface :-( As such, it violates some basic assumptions > made by the usbserial core. The patch below implements support for the > serial port by adding a short but ugly device-specific hack to > usb-serial.c, along with the necessary changes to mos7720.c (the > existing driver for Moschip's dual serial port device). Works well for > me and doesn't break anyone else, but I suspect the hack may disqualify > it for inclusion in the kernel. I don't think you need to do that. Just reorder and reassign the endpoints in the driver itself, don't worry about what the usb-serial core found, if you don't use those, no harm done. So with that type of change, this patch should only touch the driver itself, and I would have no problem applying that to the tree. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
