Re: [PATCH] usb: musb: support for OFF-mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ext Gupta, Ajay Kumar wrote:
-----Original Message-----
From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-
owner@xxxxxxxxxxxxxxx] On Behalf Of Arnaud Mandy
Sent: Friday, January 22, 2010 2:58 PM
To: linux-usb@xxxxxxxxxxxxxxx
Subject: [PATCH] usb: musb: support for OFF-mode

using a wrapper between the transceiver driver and the controller
driver to signal the controller driver to turn on/off the controller
when VBUS event is detected.

based-on: Heikki Krogerus <ext-heikki.krogerus@xxxxxxxxx>
Signed-off-by: Arnaud Mandy <ext-arnaud.2.mandy@xxxxxxxxx>
---
 drivers/usb/musb/musb_core.c  |   30 +++++++++++++++++-
 drivers/usb/musb/musb_core.h  |   17 +++++++++-
 drivers/usb/musb/omap2430.c   |   66
++++++++++++++++++++++++++++++++++++++++-
 drivers/usb/otg/otg.c         |   16 ++++++++++
 drivers/usb/otg/twl4030-usb.c |    2 +

This patch would support off mode for boards with twl4030 phy. How about
Boards with ISP1504 which uses nop-transceiver where we don't get any
PHY interrupt and so there is no one to call 'musb_power_controller()'.

Can we add something in 'arch/arm/mach-omap2/pm34xx.c' for such boards?


Yes you can call the otg wrapper from anywhere
otg_power_controller(struct otg_transceiver *x, bool vbus)
you just need to include otg.h and get the transceiver pointer with otg_get_transceiver()

But after your comment we are thinking about using a notifier to trigger the musb_power_controller instead of a otg specific wrapper, in this way, any vbus level trigger change will be in one place. the notifier chain can also be executed from anywhere which detects vbus level changes.

Is there any omap3 platform which would have vbus only connected to the transceiver?

 include/linux/usb/otg.h       |   11 +++++++
 6 files changed, 137 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux