Re: [PATCH] USB: serial: Fix atomic schedule in u_serial.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 21, 2010 at 02:59:20PM +0000, Alan Cox wrote:
> > Disabling tty_low_latency doesn't work,see the below thread:
> > http://www.spinics.net/lists/linux-usb/msg26424.html
> 
> Interesting. I've just been reading the code to look at this in more
> depth and I think I need a barf bucket. It's not using tty refcounts, its
> not locking properly, it even tests and detects a now invalid pointer and
> then proceeds to use it. I imagine with a bit of thought its exploitable
> too.
> 
> Probably someone should rewrite it. The usb serial layer has all this
> mess sorted out. u_serial appears to be a relative of a last century
> usbserial.

Yeah, I think it was based on a very old version of that :(

I don't think it can use the usb serial layer, as it is a different type
of driver (runs on the gadget, not on the host), but I'll look into it,
it might not be all that bad...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux