Re: My transfer ring grew to 740 segments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 13 Mar 2025 11:45:30 +0200, Neronin, Niklas wrote:

> IMO the driver used to print a long and repetitive debug message,
> which is why I changed it.
> Admittedly, my design does not handle hundreds of segments well.
> 
> Before:
>   For each segment or until the segment containing the TD end TRB:
> 	"Looking for event-dma %016llx trb-start %016llx trb-end %016llx seg-start %016llx seg-end %016llx"
> 
> After:
>   "Event dma %pad for ep %d status %d not part of TD at %016llx - %016llx"
>   For each segment:
> 	"Ring seg %u dma %pad"
> 
> Probably, would have been better to loop from TD start seg to end seg.

That's actually what the old code did, it only printed segments which
contained parts of the TD. Usually one, sometimes two.

New version always prints at least two lines.

I thought that maybe you wanted it for some reason, but if it was only
a matter preserving the old annoying behavior, I think it can go away :)


Regards,
Michal




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux